googleapis / googleapis/release-please-action

Option "include-component-in-tag" is ignored

Open
#951 9 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
2.5k
Forks
327
PR merge metrics
No merged PRs in 30d

Description

### TL;DR

Setting the option `include-component-in-tag: true` has no effect, no matter whether you set it in the workflow file or the manifest file.

### Expected behavior

When setting the option `include-component-in-tag: true` the tags should be generated with a component name, like `comp_v1.0`.

### Observed behavior

No matter where I set the option I still only get tags like `v1.0`, no component name is prepended. I'm not 100% sure where the component name is supposed to come from actually since there is no setting to define one, so maybe I'm missing some detail to get this working.

### Action YAML

```yaml
name: Workflow name
run-name: "${{github.workflow}}: ${{github.event.head_commit.message}}"
concurrency: build-${{github.ref}}

on:
workflow_dispatch:
push:
branches-ignore:
- 'stable'

jobs:
release:
name: Do release
runs-on: self-hosted
steps:
- name: Release
uses: google-github-actions/release-please-action@v4
with:
token: ${{ secrets.RELEASE_PLEASE_TOKEN }}
config-file: release-please-config.json
manifest-file: .release-please-manifest.json
target-branch: dev-release
include-component-in-tag: true # <--- No effect
```

### Log output

```text
Run google-github-actions/release-please-action@v4
Running release-please version: 16.5.0
❯ Fetching release-please-config.json from branch dev-release
❯ Fetching .release-please-manifest.json from branch dev-release
✔ Building releases
✔ Building strategies by path
❯ .: simple
❯ src/blocks/gfx: simple
❯ Fetching release-please-config.json from branch dev-release
❯ Fetching .release-please-manifest.json from branch dev-release
✔ Building pull requests
✔ Building strategies by path
❯ .: simple
❯ src/blocks/gfx: simple
⚠ Multiple paths for : ., src/blocks/gfx
✔ Collecting release commit SHAs
❯ release search depth: 400
❯ Fetching releases with cursor undefined
❯ Found release for path src/blocks/gfx, v1.8.0
⚠ Expected 2 releases, only found 1
⚠ Missing 1 paths: .
❯ looking for tagName: v1.4.0
❯ found: v1.4.0 47743b360e9814b2cff46014e5bf32a1bf5b5575
❯ release for path: src/blocks/gfx, version: 1.8.0, sha: 4decc9d05250e2f4e62488b28f2191cb2f8f3720
❯ release for path: ., version: 1.4.0, sha: 47743b360e9814b2cff46014e5bf32a1bf5b5575
✔ Collecting commits since all latest releases
❯ commit search depth: 500
❯ Set(2) {
'4decc9d05250e2f4e62488b28f2191cb2f8f3720',
'47743b360e9814b2cff46014e5bf32a1bf5b5575'
}
❯ Fetching merge commits on branch dev-release with cursor: undefined
❯ Backfilling file list for commit: 69eec52ac5d6a9d3264d3070249ad3e49b6f0ee1
❯ Found 1 files
❯ Backfilling file list for commit: 4decc9d05250e2f4e62488b28f2191cb2f8f3720
❯ Found 2 files
❯ Backfilling file list for commit: 390442391e28051085e5b3e63af6b8038112088d
❯ Found 2 files
❯ Backfilling file list for commit: fcf0d3bace5d282c9cb267ce68691d5b6cc8fb2a
❯ Found 2 files
❯ Backfilling file list for commit: cb14e805a25dc4f9508a56092ae8d048fca52472
❯ Found 1 files
❯ Backfilling file list for commit: f58d7b2bedacd0414451b1900d195f73ef5d13f1
❯ Found 1 files
❯ Backfilling file list for commit: fb2c9176892af696dbe17d5f493f076873bfc4f5
❯ Found 2 files
❯ Backfilling file list for commit: 65cdcfe548128ca325226629c0683a90616cbe91
❯ Found 2 files
❯ Backfilling file list for commit: 874a4e8d709cb5d7f3cd7d7a4d1a748c86cbbdc0
❯ Found 1 files
❯ Backfilling file list for commit: 27529828d45790598e76b085029ea6a50b82cf6d
❯ Found 2 files
❯ Backfilling file list for commit: 4a943dd823c29ab0c28015f7241a92a7472e1a6e
❯ Found 2 files
❯ Backfilling file list for commit: dda72f7beb9e14857c47570689ed0e25a50df56c
❯ Found 1 files
❯ Backfilling file list for commit: 2b4a84a4b783b9ff9bb30f0f4d0567d5bc1e752e
❯ Found 1 files
❯ Backfilling file list for commit: 8f1052e9506e9ff024ebebd46f85a3abc034d5f3
❯ Found 2 files
❯ Backfilling file list for commit: 24d18c6e97941648653e0e2acd434c1da8c727c2
❯ Found 2 files
❯ Backfilling file list for commit: 946e4017cafd9f1522236ed43cda23036165d7eb
❯ Found 1 files
❯ Backfilling file list for commit: 7ef52de046a186ba891f6691715956bbb0462ced
❯ Found 2 files
❯ Backfilling file list for commit: 2686084c2b68974353610202ca0ae5148479bc1c
❯ Found 2 files
❯ Backfilling file list for commit: 8a7628f8fb6e9a3db51e01aed1c5e0bb4a5d5686
❯ Found 1 files
❯ Backfilling file list for commit: 47743b360e9814b2cff46014e5bf32a1bf5b5575
❯ Found 3 files
❯ Backfilling file list for commit: 5e393b3eb5577d7bafd6cc51d881e242fb766568
❯ Found 3 files
❯ Backfilling file list for commit: ff9b9c4ba8d8ca4cf0deb16d5d2ca18372be6f69
❯ Found 1 files
❯ Backfilling file list for commit: f9a7bf9adbfd3b238cf2ce973a8516bf7a442d54
❯ Found 1 files
❯ Backfilling file list for commit: 9f6eb033c4c7ac74504b00d74b2b1e78ee2f2992
❯ Found 1 files
❯ Backfilling file list for commit: 48010c1b0ee2d199ae4f0aabea7e621c12b17eb5
❯ Found 3 files
✔ Splitting 19 commits by path
✔ Building candidate release pull request for path: .
❯ type: simple
❯ targetBranch: dev-release
❯ commit could not be parsed: 4decc9d05250e2f4e62488b28f2191cb2f8f3720 Merge pull request #26 from ***/release-please--branches--dev-release
❯ commit could not be parsed: fcf0d3bace5d282c9cb267ce68691d5b6cc8fb2a Revert downgrade
❯ commit could not be parsed: f58d7b2bedacd0414451b1900d195f73ef5d13f1 Downgrade release please
❯ commit could not be parsed: fb2c9176892af696dbe17d5f493f076873bfc4f5 Merge pull request #25 from ***/release-please--branches--dev-release
❯ commit could not be parsed: 27529828d45790598e76b085029ea6a50b82cf6d Merge pull request #24 from ***/release-please--branches--dev-release
❯ commit could not be parsed: 8f1052e9506e9ff024ebebd46f85a3abc034d5f3 Merge pull request #23 from ***/release-please--branches--dev-release
❯ commit could not be parsed: 946e4017cafd9f1522236ed43cda23036165d7eb Include component in tag
❯ commit could not be parsed: 7ef52de046a186ba891f6691715956bbb0462ced Merge pull request #22 from ***/release-please--branches--dev-release
❯ commits: 5
✔ Considering: 5 commits
❯ component:
❯ pull request title pattern: undefined
✔ No user facing commits found since 47743b360e9814b2cff46014e5bf32a1bf5b5575 - skipping
✔ Building candidate release pull request for path: src/blocks/gfx
❯ type: simple
❯ targetBranch: dev-release
❯ commits: 1
✔ Considering: 1 commits
❯ component:
❯ pull request title pattern: undefined
❯ running plugin: Merge
✔ Merging 1 pull requests
⚠ pullRequestTitlePattern miss the part of '${scope}'
⚠ pullRequestTitlePattern miss the part of '${component}'
⚠ pullRequestTitlePattern miss the part of '${version}'
✔ Looking for open release pull requests
✔ found 0 open release pull requests.
✔ Looking for snoozed release pull requests
✔ found 0 snoozed release pull requests.
❯ Fetching src/blocks/gfx/CHANGELOG.md from branch dev-release
❯ Fetching src/blocks/gfx/version.txt from branch dev-release
❯ Fetching .release-please-manifest.json from branch dev-release
⚠ file src/blocks/gfx/version.txt did not exist
✔ Starting GitHub PR workflow...
✔ Successfully found branch HEAD sha "69eec52ac5d6a9d3264d3070249ad3e49b6f0ee1".
✔ Skipping branch creation step...
✔ Got the latest commit tree
✔ Successfully created a tree with the desired changes with SHA f87bffc6cd9c42297f9a9b0f73173bb3c2291ab6
✔ Successfully created commit. See commit at https://api.github.com/repos/***/git/commits/066c1f3424207319cae33860c89435b41eca60f1
✔ Updating reference heads/release-please--branches--dev-release to 066c1f3424207319cae33860c89435b41eca60f1
✔ Successfully updated reference release-please--branches--dev-release to 066c1f3424207319cae33860c89435b41eca60f1
✔ Successfully opened pull request available at url: https://api.github.com/repos/***/pulls/27.
✔ Successfully opened pull request: 27.
✔ Successfully added labels autorelease: pending to issue: 27
```

### Additional information

Manifest file `release-please-config.json`, here I also added `include-component-in-tag: true` but to no effect:
```json
{
"include-component-in-tag": true,
"packages": {
".": {
"changelog-path": "CHANGELOG.md",
"release-type": "simple",
"bump-minor-pre-major": false,
"bump-patch-for-minor-pre-major": false,
"draft": false,
"prerelease": false,
"exclude-paths": ["src/blocks/gfx"],
"include-component-in-tag": true
},
"src/blocks/gfx": {
"changelog-path": "CHANGELOG.md",
"release-type": "simple",
"bump-minor-pre-major": false,
"bump-patch-for-minor-pre-major": false,
"draft": false,
"prerelease": false,
"include-component-in-tag": true
}
},
"$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json"
}
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.