googleapis / googleapis/release-please-action
Trying to re-release old versions even with manifest config
- Dominant language
- TypeScript
- Stars
- 2.5k
- Forks
- 328
- PR merge metrics
- No merged PRs in 30d
Description
### TL;DR
Trying to re-release old versions even with manifest config
### Expected behavior
The correct versions to be released
### Observed behavior
Please see: https://github.com/cha0s/flecks/pull/26/files
You can see right at the top is the existing manifest config.
You can also see that it is trying to create a "new" release for e.g. `packages/dox`: from version `4.0.10` to `4.0.3`(!!). It has many mistakes like this. No matter how many times I try to fix, it still does the wrong thing. I even added [another `bootstrap-sha`](https://github.com/cha0s/flecks/blob/f7868ee63a84760ede4be89e89391eef4e3dfae3/build/release-please-config.json#L2) to avery recent commit and it still does the wrong thing.
### Action YAML
```yaml
on:
push:
branches:
- master
name: release-please
jobs:
release-please:
runs-on: ubuntu-latest
permissions:
contents: write
id-token: write
pull-requests: write
steps:
- uses: GoogleCloudPlatform/release-please-action@v3
id: release
with:
token: ${{secrets.FLECKS_GITHUB_TOKEN}}
command: manifest
config-file: build/release-please-config.json
manifest-file: build/.release-please-manifest.json
- if: ${{steps.release.outputs.releases_created}}
uses: actions/checkout@v2
- if: ${{steps.release.outputs.releases_created}}
uses: actions/setup-node@v2
with:
cache: "npm"
node-version: 18
registry-url: "https://registry.npmjs.org"
- if: ${{steps.release.outputs.releases_created}}
env:
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
run: |
npm ci
npm run build
npm run publish
```
### Log output
```text
It won't let me paste all the logs ("There was an error creating your issue: body is too long (maximum is 65536 characters).").
Here's a gist: https://gist.github.com/cha0s/67a0aa3cb4a5d3b27819d4ebd5f7fe9c
```
### Additional information
_No response_
Contributor guide
Research direction
Start by reviewing the release-please-action workflow configuration, especially build/release-please-config.json and build/.release-please-manifest.json in the linked flecks pull request. Compare the reported gist logs with the manifest and Action YAML, then trace how the manifest release versions are interpreted. Done means old versions are not proposed as new releases and the correct package versions are selected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, typescript
- Domain
- ci-cd, release
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100