googleapis / googleapis/release-please-action

extra-file is not updated by release-please

Open
#1,130 1 comment 1 reaction 1 assignee Claimed by @chingor13 View on GitHub
priority: p2 type: bug
Dominant language
TypeScript
Stars
2.5k
Forks
327
PR merge metrics
No merged PRs in 30d

Description

Thanks for stopping by to let us know something could be better!

**PLEASE READ**: If you have a support contract with Google, please create an issue in the [support console](https://cloud.google.com/support/) instead of filing on GitHub. This will ensure a timely response.

Is this a client library issue or a product issue? We will only be able to assist with issues that pertain to the behaviors of this library. If the issue you're experiencing is due to the behavior of the product itself, please visit the [Support page](https://cloud.google.com/support) to reach the most relevant engineers.

If the support paths suggested above still do not result in a resolution, please provide the following details.

Please provide the following details.

#### Environment details

- OS: github workflow on ubuntu-latest
- `release-please` version: googleapis/release-please-action@v4

#### Steps to reproduce

1. Setting up new rust project
2. bootstrap it with release-please
3. adding extra file sw.js in public folder with content: const CACHE_VERSION = "0.0.0"; // x-release-please-version
4. release-please-config.json:

```json
{
"packages": {
".": {
"changelog-path": "CHANGELOG.md",
"release-type": "rust",
"bump-minor-pre-major": false,
"bump-patch-for-minor-pre-major": false,
"draft": false,
"prerelease": false,
"extra-files": [
{
"type": "generic",
"path": "public/sw.js"
}
]
}
},
"$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json"
}
```

5. setting up github workflow with content:

```yaml
name: release-please

description: |
Functional workflow for release-please. Automatically creates a release PR with version bump,
changelog, and Git tag based on conventional commits.

on:
push:
branches:
main

jobs:
release:
name: Create release PR (release-please)
runs-on: ubuntu-latest
steps:
- uses: googleapis/release-please-action@v4
with:
token: ${{ secrets.GITHUB_TOKEN }}
release-type: rust
target-branch: main
config-file: release-please-config.json
manifest-file: .release-please-manifest.json
```

6. push it with "fix: test the bug" to github
7. result: sw.js is not updated.

Making sure to follow these steps will guarantee the quickest resolution possible.

Thanks!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.