googleapis / googleapis/release-please-action

Updating `devDependencies` in monorepo triggers release

Open
#1,045 0 comments 1 reaction 0 assignees View on GitHub
priority: p2 type: bug
Dominant language
TypeScript
Stars
2.5k
Forks
327
PR merge metrics
No merged PRs in 30d

Description

#### Environment details

- Programming language: JS
- OS: ubuntu-latest
- Language runtime version: I'm not sure what this refers to.
- Package version: v4

#### Steps to reproduce

Here's a live example: https://github.com/eslint/rewrite/pull/124

Since the last release, we had a releasable change in the `@eslint/core` package only.

In the same monorepo, `@eslint/plugin-kit` and `@eslint/compat` packages have `@eslint/core` in `devDependencies` (not `dependencies`).

The behavior I'd expect is that the release PR updates `devDependencies` in these two packages, but does not update the `version` field, because updating `devDependencies` should not be a reason to bump the version and release the package.

The actual behavior is that the release PR updates `devDependencies` in these two packages, and updates the `version` field. Merging the PR will likely release these two packages too, which is unnecessary as there were no releasable changes in them.

Contributor guide

Open the contributing guide

Research direction

Start by examining the live example in https://github.com/eslint/rewrite/pull/124 and trace how the release PR handles devDependencies in the monorepo. Confirm the behavior for @eslint/plugin-kit and @eslint/compat; done means their devDependency updates do not change the version field or trigger releases when they have no releasable changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
release
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.