googleapis / googleapis/python-aiplatform

ADK async_stream_query doesn't capture error

Open
#7,001 1 comment 0 reactions 1 assignee Claimed by @maxgasztych View on GitHub
api: vertex-ai
Dominant language
Python
Stars
905
Forks
465
Avg merge
1d 13h
Merged PRs (30d)
44

Description

At https://github.com/googleapis/python-aiplatform/blob/main/vertexai/agent_engines/templates/adk.py#L1204, there is a try: and finally: block but no except:.

This means that any error that occurs in a query request doesn't get captured and instead returns a blank string.
Can we add exception handling here and return back to the client?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.