googleapis / googleapis/librarian

nodejs: package.json in a new library misses "long" dependency

Open Beginner friendly
#6,501 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

priority: p2
Dominant language
Go
Stars
45
Forks
62
Avg merge
18h 32m
Merged PRs (30d)
175

Description

It failed in Node 24 unit test:

> @google-cloud/agentregistry@0.1.0 compile
> tsc -p . && cp -r protos build/ && minifyProtoJson

protos/protos.d.ts:16:23 - error TS2307: Cannot find module 'long' or its corresponding type declarations.

16 import Long = require("long");
                         ~~~~~~


Found 1 error in protos/protos.d.ts:16

Originally posted by @suztomo in https://github.com/googleapis/google-cloud-node/issues/8673#issuecomment-4743750542

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the new library's package.json and the compile command shown in the report; inspect how its dependencies are generated. Confirm the missing long dependency and run the Node 24 unit test or compile step again. Done means the generated library compiles without the TS2307 error.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js, typescript
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.