googleapis / googleapis/google-http-java-client
GZipEncoding should throw IOException from close
- Dominant language
- Java
- Stars
- 1.4k
- Forks
- 473
- PR merge metrics
- No merged PRs in 30d
Description
The close method below swallows IOExceptions. That seems unnecessary and dangerous.
```
public class GZipEncoding implements HttpEncoding {
public String getName() {
return "gzip";
}
public void encode(StreamingContent content, OutputStream out) throws IOException {
// must not close the underlying output stream
OutputStream out2 =
new BufferedOutputStream(out) {
@Override
public void close() throws IOException {
// copy implementation of super.close(), except do not close the underlying output
// stream
try {
flush();
} catch (IOException ignored) {
// Nothing else we can do here
}
}
};
GZIPOutputStream zipper = new GZIPOutputStream(out2);
content.writeTo(zipper);
// cannot call just zipper.finish() because that would cause a severe memory leak
zipper.close();
}
}
```
Contributor guide
Assessment
This issue has not been assessed yet.