googleapis / googleapis/google-cloud-swift
Tests should use `_ProtoJSON{Encoder,Decoder}`
Open
type: cleanup
- Dominant language
- Swift
- Stars
- 26
- Forks
- 10
- Avg merge
- 12h 56m
- Merged PRs (30d)
- 211
Description
> Should we be using _ProtoJSONDecoder?
_Originally posted by @chingor13 in https://github.com/googleapis/google-cloud-swift/pull/831#discussion_r3991833686_
In fact, all our serialization / deserialization tests should use the types we intend to use.
Contributor guide
Research direction
Search the repository for serialization and deserialization tests, then inspect the existing _ProtoJSONEncoder and _ProtoJSONDecoder types they are intended to use. Update the tests so they exercise those intended types, and run the affected test suite to confirm all serialization tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Needs clarification
- Newbie friendliness
- 48/100