googleapis / googleapis/google-cloud-rust

Generate `FromProto` and `ToProto` conversions for `wkt::DescriptorProto`

Open
#6,616 0 comments 0 reactions 1 assignee Claimed by @haphungw View on GitHub
api: bigquery
Dominant language
Rust
Stars
955
Forks
144
Avg merge
1d 5h
Merged PRs (30d)
279

Description

We added manual `FromProto` and `ToProto` implementations for `wkt::DescriptorProto` to convert to and from `prost_types::DescriptorProto` so it could be used by BigQuery.

This conversion is narrow and intentionally incomplete as it drops several AST fields because `prost_types::DescriptorProto` does not contain all of the fields present in our `wkt::DescriptorProto` (due to being generated off a different version of the protos).

We should update the librarian code generator to automatically emit these WKT conversions rather than maintaining a manual stopgap.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.