googleapis / googleapis/google-cloud-rust

Add `x-guploader-uploadid` header to storage tracing attributes

Open
#4,753 1 comment 0 reactions 0 assignees View on GitHub
priority: p3 type: feature request
Dominant language
Rust
Stars
955
Forks
144
Avg merge
1d 5h
Merged PRs (30d)
279

Description

The HTTP and probably the application traces should include that header to make troubleshooting easier.

----
Code looks great!! I have one comment on the docs, happy to adjust them in this PR and/or iterate in the future before removing the feature flag.

A couple attributes you might want to look at (next?) from go/gcs-sdk-trace-semconv:

1. `http.response.header.x-guploader-uploadid` for debugging upload issues (your idea!)
2. gsutil.uri (or .source, .target) for bucket/object filtering.

_Originally posted by @westarle in https://github.com/googleapis/google-cloud-rust/pull/4740#pullrequestreview-3832903241_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.