googleapis / googleapis/google-cloud-python

ci: enable --strict flag in presubmit twine_check

Open Beginner friendly
#18,339 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
5.4k
Forks
1.8k
Avg merge
3d 4h
Merged PRs (30d)
122

Description

## Overview
The presubmit `twine_check` step in `ci/run_single_test.sh` currently runs `twine check dist/*` without `--strict` to avoid false-positive failures caused by missing `long_description_content_type` metadata in existing `setup.py` files (see #18211).
## Goal
Once `long_description_content_type="text/x-rst"` is populated across package `setup.py` files via #18211, re-enable the `--strict` flag in `ci/run_single_test.sh`:
```bash
twine check --strict dist/*

Contributor guide

Open the contributing guide

Research direction

After #18211 populates long_description_content_type in the package setup.py files, open ci/run_single_test.sh and locate the presubmit twine_check command. Enable --strict for the dist/* check, then verify the presubmit check completes successfully with the stricter validation.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, shell
Domain
build-system, ci-cd
Issue type
Feature
Difficulty
1/5
Estimated time
Under an hour
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
76/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.