googleapis / googleapis/google-cloud-python

Support UTF-8 data in `JsonProperty`

Open
#15,830 1 comment 0 reactions 1 assignee Claimed by @daniel-sanche View on GitHub
api: datastore priority: p3 type: feature request
Dominant language
Python
Stars
5.4k
Forks
1.8k
Avg merge
3d 4h
Merged PRs (30d)
122

Description

We have datastore entities with a property that holds JSON data. The entities itself were written using a datastore library in a different language than Python. The data includes unescaped UTF-8 characters (which should be legal in JSON, and is generally well supported).

When using an NDB `JsonProperty` to access this data from within Python, however, this breaks. This is because `JsonProperty` only supports ascii data:

```python
def _from_base_type(self, value):
if not isinstance(value, str):
value = value.decode("ascii")
return json.loads(value)
```

Could `JsonProperty` be adapted to decode `utf-8`, to have better interoperability between different languages working on the same data?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.