googleapis / googleapis/google-cloud-php
dev: Ensure Ads and Common Protos new component parameters are derived correctly
- Dominant language
- PHP
- Stars
- 1.2k
- Forks
- 463
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 145
Description
We have a command which builds new components from proto files and calculates their parameters based on the protos provided:
```
./dev/google-cloud component:new
```
However, when a component has the namespace `Google\Ads`, custom parameters must be provided in order to configure the appropriate composer package name and github repository:
- The composer package name should use `googleapis` as the vendor instead of `google`, e.g. `googleads/[project-name]` instead of `google/[project-name]`
- The github repo should be `googleapis/php-ads-[project-name]`
The same is true for `CommonProtos` libraries - if no GAPIC clients exist, we append `CommonProtos` to the component name, and `-common-protos` to the package and repo names.
See go/cloud-sdk-php-new-component-heuristics
Contributor guide
Research direction
Start with ./dev/google-cloud component:new and trace how it derives parameters from proto files, focusing on Google\Ads and CommonProtos namespaces. Generate examples for both cases, including a CommonProtos library with no GAPIC clients, and verify that the composer package and GitHub repository names match the requested conventions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100