googleapis / googleapis/google-cloud-node

@google-cloud/common: teeny-request using removed timeout option from node-fetch

Open
#7,998 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
TypeScript
Stars
3.2k
Forks
712
Avg merge
2d 3h
Merged PRs (30d)
99

Description

It seems that teeny-request is using a [timeout](https://github.com/googleapis/google-cloud-node/blob/7fad2f6e2ef0b16ab87a92ae471136fe6f2655ef/core/packages/teeny-request/src/index.ts#L35) attribute that was a valid option in node-fetch v2 (see [Options](https://github.com/node-fetch/node-fetch/tree/2.x?tab=readme-ov-file#options)) but seems to have been removed in node-fetch v3 (compare with [Options](https://github.com/node-fetch/node-fetch/tree/main?tab=readme-ov-file#options)).

It seems that as of node-fetch v3 the timeout should be implemented using an [AbortSignal](https://github.com/node-fetch/node-fetch/tree/main?tab=readme-ov-file#request-cancellation-with-abortsignal).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.