googleapis / googleapis/google-cloud-node

Option to eliminate transitive production dependency on jsdoc

Open
#7,752 3 comments 1 reaction 0 assignees View on GitHub
library: google-cloud-node-core priority: p3 type: question
Dominant language
TypeScript
Stars
3.2k
Forks
712
Avg merge
2d 3h
Merged PRs (30d)
99

Description

Hi, our security tools are complaining about jsdoc; so, I am trying to eliminate our transitive dependency on jsdoc.
```
$ npm ls --omit=dev jsdoc

└─┬ @google-cloud/secret-manager@4.2.0
└─┬ google-gax@3.5.3
└─┬ protobufjs-cli@1.1.0
└── jsdoc@4.0.0
```
I can effectively accomplish that with a postinstall script that removes jsdoc from node_modules, since our app doesn't use any of the features that require jsdoc. However, I have been asked to query about the possibility of eliminating jsdoc as a prod dependency.

Could it make sense for google-gax to provide multiple packages, including one that is jsdoc-free, so that dependent modules could have only a dev dependency on jsdoc?

Thanks.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.