googleapis / googleapis/google-cloud-node

[securitycenter] v2 client's `apiEndpoint` property is wrong when a regional endpoint is specified

Open
#7,703 4 comments 0 reactions 0 assignees View on GitHub
library: google-cloud-node-core priority: p2 size: m type: bug
Dominant language
TypeScript
Stars
3.2k
Forks
712
Avg merge
2d 3h
Merged PRs (30d)
99

Description

### Please make sure you have searched for information in the following guides.

- [X] Search the issues already opened: https://github.com/GoogleCloudPlatform/google-cloud-node/issues
- [X] Search StackOverflow: http://stackoverflow.com/questions/tagged/google-cloud-platform+node.js
- [X] Check our Troubleshooting guide: https://googlecloudplatform.github.io/google-cloud-node/#/docs/guides/troubleshooting
- [X] Check our FAQ: https://googlecloudplatform.github.io/google-cloud-node/#/docs/guides/faq
- [X] Check our libraries HOW-TO: https://github.com/googleapis/gax-nodejs/blob/main/client-libraries.md
- [X] Check out our authentication guide: https://github.com/googleapis/google-auth-library-nodejs
- [X] Check out handwritten samples for many of our APIs: https://github.com/GoogleCloudPlatform/nodejs-docs-samples

### A screenshot that you have tested with "Try this API".

n/a

### Link to the code that reproduces this issue. A link to a **public** Github Repository or gist with a minimal reproduction.

https://gist.github.com/hegemonic/cf807026d8b83c14aa0b225b16967599

### A step-by-step description of how to reproduce the issue, based on the linked reproduction.

Run the code. It creates a v2 `SecurityCenterClient`; sets the `apiEndpoint` to `securitycenter.me-central2.rep.googleapis.com`; and prints the expected and actual `apiEndpoint` for the client.

### A clear and concise description of what the bug is, and what you expected to happen.

The code prints the following:

```
expected apiEndpoint: securitycenter.me-central2.rep.googleapis.com
actual apiEndpoint: securitycenter.googleapis.com
client._opts.apiEndpoint: securitycenter.me-central2.rep.googleapis.com
```

I expected it to print the following:

```
expected apiEndpoint: securitycenter.me-central2.rep.googleapis.com
actual apiEndpoint: securitycenter.me-central2.rep.googleapis.com
client._opts.apiEndpoint: securitycenter.me-central2.rep.googleapis.com
```

### A clear and concise description WHY you expect this behavior, i.e., was it a recent change, there is documentation that points to this behavior, etc. **

* If I specify an API endpoint, the client object shouldn't say that it's using the default endpoint.
* You shouldn't need to look at private properties to figure out which endpoint the client is using.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.