googleapis / googleapis/google-cloud-node
Performance impact of calling JSON.stringify in loadProtoJSON
Open
library: google-cloud-node-core
size: l
type: feature request
- Dominant language
- TypeScript
- Stars
- 3.2k
- Forks
- 712
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 99
Description
We're using the compute engine InstancesClient and notice that every time we create an instance of it we spend a bunch of time in JSON.stringify as it's generating a 1.4 MB object. (This is running in a .333 vCPU cloud function.)
This is the call stack:
```
at GrpcClient.loadProtoJSON (/workspace/node_modules/google-gax/build/src/fallback.js:117:38)
at new InstancesClient (/workspace/node_modules/@google-cloud/compute/build/src/v1/instances_client.js:149:38)
```
Maybe that can be optimized somehow?
Contributor guide
Assessment
This issue has not been assessed yet.