googleapis / googleapis/google-cloud-node

improve grpc-fallback browser-test

Open
#7,677 0 comments 0 reactions 0 assignees View on GitHub
library: google-cloud-node-core type: process
Dominant language
TypeScript
Stars
3.2k
Forks
712
Avg merge
2d 3h
Merged PRs (30d)
99

Description

Separating out from googleapis/google-cloud-node-core#177 - the it 'should handle an error' test in browser-test/test/test.grpc-fallback.ts does not properly assert on the error message, and doing so is going to require some gymnastics to adjust setMockFallbackResponse. @sofisl and I experimented a bit today and we can note that
- When we tried constructing an EchoClient and calling the echo method like the "makes a request" test, we do not properly get an error
- When reverting the test to its previous use of sinon, we see a SymbolIterator error
- When we try to assert on the error message right now, we get a "Fail to fetch" error from gaxios - it seems that the mock fallback response function doesn't properly pass the adapter all the way down to gaxios when it's being called from the stub, rather than from the method itself

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.