googleapis / googleapis/google-cloud-node

to unpin nock we need to change the sinon timers

Open
#7,674 0 comments 0 reactions 0 assignees View on GitHub
library: google-cloud-node-core size: s type: process
Dominant language
TypeScript
Stars
3.2k
Forks
712
Avg merge
2d 3h
Merged PRs (30d)
99

Description

see https://b.corp.google.com/issues/436299453

this version of nock breaks us: https://github.com/nock/nock/pull/2880/files

we need to add fake timers to use this version.

https://github.com/googleapis/google-auth-library-nodejs/pull/2108

also posted: https://github.com/nock/nock/issues/2897

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.