googleapis / googleapis/google-cloud-node

feat(gax): Migrate from retry-request to gaxios for retry functionality

Open
#7,661 5 comments 2 reactions 0 assignees View on GitHub
library: google-cloud-node-core size: m type: feature request
Dominant language
TypeScript
Stars
3.2k
Forks
712
Avg merge
2d 3h
Merged PRs (30d)
99

Description

## Summary

The `gax` package still depends on `retry-request`, which has been deprecated since July 2024. The deprecation notice in the [original repository](https://github.com/stephenplusplus/retry-request) states:

> THIS REPOSITORY AND PACKAGE WILL BE DEPRECATED IN JULY 2024. RELEVANT FUNCTIONALITIES HAVE BEEN MOVED TO GOOGLEAPIS/GAXIOS

Since both `retry-request` and `gaxios` are now maintained in this monorepo, it would be beneficial to migrate `gax` to use `gaxios` for retry functionality.

## Current State

- `gax@5.0.6` (latest stable) depends on `retry-request@^8.0.0`
- `gax@6.0.1-experimental` still depends on `retry-request@^8.0.0`
- `retry-request` was migrated to this monorepo in PR googleapis/google-cloud-node-core#858, but not removed from `gax`

## Impact

All downstream packages (`@google-cloud/kms`, `@google-cloud/storage`, etc.) inherit this deprecated dependency, which may cause concerns for users running security audits on their dependencies.

## Suggested Solution

Migrate the retry logic in `gax` to use `gaxios` instead of `retry-request`, then deprecate/remove the `retry-request` package from this monorepo.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.