googleapis / googleapis/google-cloud-node

why googclient_traceparent, why not just traceparent

Open
#7,629 7 comments 3 reactions 0 assignees View on GitHub
api: pubsub priority: p3 type: feature request
Dominant language
TypeScript
Stars
3.2k
Forks
712
Avg merge
2d 3h
Merged PRs (30d)
99

Description

https://github.com/googleapis/nodejs-pubsub/blob/c1bed9e1decd4175232ca3aaf88ac7c58249720b/src/telemetry-tracing.ts#L243

I noticed that the client sets + extracts trace context using `googclient_traceparent` instead of the standard `traceparent`. This makes it incompatible with vanilla OpenTelemetry context propagation, requiring manual extraction and re-injection.

- Is there a specific reason for this customization?
- Would it be possible to use the standard traceparent key, or at least provide an option to enable it?

This would improve interoperability with OpenTelemetry out of the box.

Thanks!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.