googleapis / googleapis/google-cloud-node

EntryJson interface has incorrect type for insertId

Open
#7,563 0 comments 0 reactions 0 assignees View on GitHub
api: logging priority: p2 type: bug
Dominant language
TypeScript
Stars
3.2k
Forks
712
Avg merge
2d 3h
Merged PRs (30d)
99

Description

[interface EntryJson](https://github.com/googleapis/nodejs-logging/blob/a53b8f882452c2854d0b47bf92d2efdbada785dc/src/entry.ts#L70)
```typescript
export interface EntryJson {
timestamp: Timestamp;
insertId: number;
jsonPayload?: google.protobuf.IStruct;
textPayload?: string;
httpRequest?: google.logging.type.IHttpRequest;
trace?: string;
spanId?: string;
traceSampled?: boolean;
}
```

The property `insertId` has the incorrect type - it should be `string` as per https://cloud.google.com/logging/docs/reference/v2/rest/v2/LogEntry (and the other interfaces in the same file)

#### Environment details

- `@google-cloud/logging` version: 11.2

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.