googleapis / googleapis/google-cloud-node

transitive dependency on deprecated `punycode` node module

Open
#7,502 5 comments 1 reaction 1 assignee Assigned to @cindy-peng View on GitHub
api: clouderrorreporting api: error-reporting priority: p3 type: bug
Dominant language
TypeScript
Stars
3.2k
Forks
712
Avg merge
2d 3h
Merged PRs (30d)
99

Description

This library transitively depends on `ent`, which uses the now deprecated node module `punycode`.
```
npm ls ent
...
└─┬ ...
└─┬ @google-cloud/error-reporting@3.0.5
└─┬ @google-cloud/common@4.0.3
└── ent@2.2.0
```

This results in a deprecation warning when running on node >= 21:
```
(node:23520) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
```

This has been adressed in `@google-cloud/common`, see: https://github.com/googleapis/nodejs-common/issues/812 - however `@google-cloud/error-reporting` does not depend on an up to date version of this library.

So `@google-cloud/common` must be updated to maintain compatibility with upcoming node releases. Edit: more precisely, `@google-cloud/common` has been updated on the main branch already here https://github.com/googleapis/nodejs-error-reporting/pull/715/files - but this is still unreleased!

#### Environment details

- OS: macos
- Node.js version: 22.0.0
- npm version: 10.5.1
- `@google-cloud/error-reporting` version: 3.0.5

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.