googleapis / googleapis/google-cloud-node

Investigate whether this workaround is still needed re: dropping resource header

Open
#7,463 0 comments 0 reactions 0 assignees View on GitHub
api: firestore library: nodejs-firestore
Dominant language
TypeScript
Stars
3.2k
Forks
712
Avg merge
2d 3h
Merged PRs (30d)
99

Description

https://github.com/googleapis/nodejs-firestore/blob/7a9d17bdd5fca3d91e66f7500c035140a7397c33/owlbot.py#L33

The code above references a workaround that we implemented because the GAPIC library was dropping the resource header (circa 2018). I think that this issue has been addressed in later versions, and if we can remove this it will simplify the post-processing we have to do.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.