googleapis / googleapis/google-cloud-node

Insert link into README, instead of nunjucks link

Open
#5,045 0 comments 0 reactions 1 assignee Claimed by @sofisl View on GitHub
priority: p2 type: bug
Dominant language
TypeScript
Stars
3.2k
Forks
712
Avg merge
2d 3h
Merged PRs (30d)
99

Description

This template uses nunjucks links which don't render properly in npm: https://github.com/googleapis/synthtool/blob/master/synthtool/gcp/templates/node_mono_repo_library/README.md

(but they do on the README)

We need to actually link the correct links instead of:

```

{% if metadata['repo']['client_documentation'] %}[client-docs]: {{ metadata['repo']['client_documentation'] }}{% endif %}
{% if metadata['repo']['product_documentation'] %}[product-docs]: {{ metadata['repo']['product_documentation'] }}{% endif %}
[shell_img]: https://gstatic.com/cloudssh/images/open-btn.png
[projects]: https://console.cloud.google.com/project
[billing]: https://support.google.com/cloud/answer/6293499#enable-billing
{% if metadata['repo']['api_id'] %}[enable_api]: https://console.cloud.google.com/flows/enableapi?apiid={{ metadata['repo']['api_id'] }}{% endif %}
[auth]: https://cloud.google.com/docs/authentication/getting-started
```
See issue for Compute: https://github.com/googleapis/google-cloud-node/pull/4983

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.