googleapis / googleapis/google-cloud-java

[sdk-platform-java] License enforcer for modified Java files

Open
#12,523 0 comments 0 reactions 0 assignees View on GitHub
priority: p4 type: bug
Dominant language
Java
Stars
2.1k
Forks
1.2k
Avg merge
1d 23h
Merged PRs (30d)
154

Description

Thanks for stopping by to let us know something could be better!

**Is your feature request related to a problem? Please describe.**
Google Copyright should be written similar to `Copyright 2010 Google LLC`. Currently, a lot of our existing code has copyright enforced as `Copyright {Year} Google Inc.`.

When we make a code change, we should enforce that the header should be updated to `Copyright {Original Year} Google LLC`

**Describe the solution you'd like**
When there is a modification to the Java code, we should have a check to ensure that the header is modified to the correct value.

**Describe alternatives you've considered**
Could the checkstyle plugin be enhanced so that it is enforced on updates? Or can we write a script to check for modified files and check that the copyright is being updated to LLC?

The current checkstyle plugin only checks that it follows the regex in `java.header`. Since we have whitelisted either `Google Inc.` and `Google LLC`, it is currently not being enforced.

**Additional context**
For more information, see the internal page about copyright.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.