googleapis / googleapis/google-cloud-java

[sdk-platform-java] `update_generation_config.sh` does not consider existing closed PRs when checking for branch existence

Open
#12,372 1 comment 0 reactions 0 assignees View on GitHub
priority: p3 type: bug
Dominant language
Java
Stars
2.1k
Forks
1.2k
Avg merge
1d 23h
Merged PRs (30d)
154

Description

For example: https://github.com/googleapis/java-pubsub/blob/ce7cb09ac5e86953815e2ead9ae9202e9b034ba6/.github/scripts/update_generation_config.sh#L109 is used to check whether we have an **open** PR with the target branch name, but unluckily java-pubsub had a **closed** PR with that branch name, so the whole action failed due to a `git push` that conflicted with the remote's contents.

An easy workaround: search for closed PRs (in this case it was [this one](https://github.com/googleapis/java-pubsub/pull/2581)) and run the action again.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.