googleapis / googleapis/google-cloud-go
spanner: integration tests should be moved out of spanner package
Open
api: spanner
priority: p3
type: cleanup
- Dominant language
- Go
- Stars
- 4.5k
- Forks
- 1.6k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 109
Description
spanner/integration_test.go is in package `spanner`. As a result, it can access package-visible members which may not be visible to public. The integration tests should use the public API only to mimic client app behaviour.
https://github.com/googleapis/google-cloud-go/pull/8923 is an example of a bug that wouldn't have happened if the tests were in a package other than `spanner`.
Contributor guide
Assessment
This issue has not been assessed yet.