googleapis / googleapis/google-cloud-go
firestore: add tracing to GetAll method
Open
api: firestore
next major: breaking change
priority: p2
type: feature request
- Dominant language
- Go
- Stars
- 4.5k
- Forks
- 1.6k
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 109
Description
`func (it *DocumentIterator) GetAll() ([]*DocumentSnapshot, error) {` doesn't have tracing but it could be useful for understanding time to retrieve all documents in tracing.
Currently there isn't a straightforward way to get the ctx which would be needed for tracing as the iterator is behind an interface without ctx.
This work would require exposing the ctx either via the interface. Or perhaps context.Background could be used?
Contributor guide
Assessment
This issue has not been assessed yet.