googleapis / googleapis/google-cloud-go

trace: Should OpenTelemetry context propagation be disabled?

Open
#10,409 0 comments 0 reactions 0 assignees View on GitHub
api: cloudtrace type: question
Dominant language
Go
Stars
4.5k
Forks
1.6k
Avg merge
1d 13h
Merged PRs (30d)
109

Description

In googleapis/google-api-go-client/issues/2639, @Pascal-Delange wrote:

> I would say it's safe to assume that the traces from the trace client sending traces itself are going to be noise >99.99% of the time (which will be more or less visible hence more or less annoying depending on the type of app being traced).
(it may still show up if you're profiling the application, but that is a different story)
A default behavior of not sending traces would seem reasonable to me.

Should OpenTelemetry context propagation be disabled in the trace client somehow, perhaps by calling [option.WithTelemetryDisabled](https://pkg.go.dev/google.golang.org/api/option#WithTelemetryDisabled) internally?

See also GoogleCloudPlatform/opentelemetry-operations-go/issues/864

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.