googleapis / googleapis/google-cloud-cpp
Cleanup (storage): Remove gRPC version guards from async_throughput_benchmark.cc
Open
api: storage
type: cleanup
- Dominant language
- C++
- Stars
- 659
- Forks
- 462
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 89
Description
MSVC + VCPKG + gRPC (<1.65.4) have some compilation issues (See: https://github.com/grpc/grpc/issues/35297). As a result I added a version guard to async_throughput_benchmark.cc. This should be removed once the version in VCPKG is updated (See: https://github.com/microsoft/vcpkg/pull/39800).
Contributor guide
Assessment
This issue has not been assessed yet.