googleapis / googleapis/google-cloud-cpp

Move microgenerator invocations to Bazel rules

Open
#14,448 0 comments 0 reactions 0 assignees View on GitHub
type: cleanup
Dominant language
C++
Stars
659
Forks
462
Avg merge
1d 2h
Merged PRs (30d)
89

Description

We use scripts to invoke the microgenerator via Bazel, for example:

https://github.com/googleapis/google-cloud-cpp/blob/34c4b4c3f61f716cb993c56dfd72486f427f1073/ci/cloudbuild/builds/generate-libraries.sh#L26-L33

It seems that kind of code really belongs in some kind of `genrule()` or a custom rule. There are many hard-coded magic strings in that call that can be converted to [`Label()`](https://bazel.build/rules/lib/builtins/Label#Label). That returns a `Label` object with all kinds of goodies: https://bazel.build/rules/lib/builtins/Label.html

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.