googleapis / googleapis/google-cloud-cpp
Use a `MockRestClient` in `storage/tests/error_injection_integration_test`
Open
api: storage
type: cleanup
- Dominant language
- C++
- Stars
- 659
- Forks
- 462
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 89
Description
This test does some low-level black magic to force a specific type of socket error.
1. The storage library should not be testing this, if anywhere, this belongs in the `RestClient` tests,
2. The storage library should just mock `RestClient` and assume it works.
Even if we decided to "move" these tests: it seems better to assume libcurl works, and just returns the right error code. If we want to make sure our wrappers work when libcurl returns the error codes corresponding to socket errors then (as libcurl cannot be easily mocked) we can use the testbench to force the error type we want.
Contributor guide
Assessment
This issue has not been assessed yet.