googleapis / googleapis/google-cloud-cpp

WinSvc.h macro mangling methods named CreateService

Open
#11,893 3 comments 0 reactions 1 assignee Claimed by @scotthart View on GitHub
cpp: generator external type: cleanup
Dominant language
C++
Stars
659
Forks
462
Avg merge
1d 2h
Merged PRs (30d)
89

Description

Because of the unfortunate preprocessor definition in WinSvc.h,
```
#ifdef UNICODE
#define CreateService CreateServiceW
#else
#define CreateService CreateServiceA
#endif // !UNICODE
```
services that define an rpc named "CreateService" get mangled when building on windows.

This is both a problem for us as well as grpc.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.