googleapis / googleapis/google-api-ruby-client

google-apis-core: ClientSecrets#to_json raises NameError

Open
#27,757 0 comments 0 reactions 1 assignee Claimed by @quartzmo View on GitHub
Dominant language
Ruby
Stars
2.9k
Forks
888
Avg merge
6m
Merged PRs (30d)
218

Description

`Google::APIClient::ClientSecrets#to_json` calls `Json.dump`, but no `Json` constant exists, so the documented serialization method raises `NameError`.

Minimal reproduction on google-apis-core 1.2.5/current:
```ruby
require "google/api_client/client_secrets"
Google::APIClient::ClientSecrets.new("installed" => {"client_id" => "id"}).to_json
# NameError: uninitialized constant Google::APIClient::ClientSecrets::Json
```

A focused correction uses `JSON.generate(to_hash, *args)`, which also preserves the `JSON.generate(secrets)` callback signature. The candidate passes the focused model, 88 targeted examples, and the cumulative 509-example core suite on Ruby 4.0.6.

I found no open issue/PR overlap. I have a minimal patch ready and can submit it after maintainer acceptance per CONTRIBUTING. The source audit and candidate preparation used AI assistance; I reviewed and verified the result.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.