googleapis / googleapis/google-api-nodejs-client

If a service is deprecated and its the last version fo the library, we need to fully deprecate it

Open
#3,898 0 comments 0 reactions 0 assignees View on GitHub
type: process
Dominant language
TypeScript
Stars
12.2k
Forks
2k
Avg merge
1d 9h
Merged PRs (30d)
24

Description

see https://github.com/googleapis/google-api-nodejs-client/pull/3890
basically lifesciences was fully deprecate it, and we have logic to delete missing service clients: https://github.com/googleapis/google-api-nodejs-client/blob/main/src/generator/download.ts#L153 but in the PR above, it happened to be the only version, so once we deleted it, we ended up having to delete the whole library. So we should have logic to fully delete it automatically so it doesn't stall the PR.

basically need to automate these commits: https://screenshot.googleplex.com/BTsMYtG9ypXm6Sd

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.