googleapis / googleapis/gapic-showcase

clarify how to add a proto file without including its autogen'd stubs

Open
#1,574 1 comment 0 reactions 0 assignees View on GitHub
priority: p2 type: bug
Dominant language
Go
Stars
183
Forks
55
Avg merge
1d 1h
Merged PRs (30d)
8

Description

I was trying to include a new `schema/` proto file in #1573 (and everything worked locally) but the GitHub presubmits kept failing unless the corresponding generated `pb.go` file was included in the PR.

I believe the intent is for the `pb.go` files to not need to be included in PRs, so we should make it clear how to do that while getting presubmits to pass. If we do need to include the generated files in PRs, we should clarify _that_.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.