googleapis / googleapis/gapic-generator-ruby

Do not look in configuration file for annotation values

Open
#71 7 comments 2 reactions 0 assignees View on GitHub
type: cleanup
Dominant language
Ruby
Stars
50
Forks
36
Avg merge
1d 1h
Merged PRs (30d)
6

Description

Updated:

Currently scopes, default_host, and port can be represented in both the proto annotations and the configuration file. Let's make it so that these values can only be represented by the proto annotations to be more strict with our interface. (@landrito)

The generator should be able to generate a working client without any annotations using reasonable default values (i.e. localhost for host, etc.). (@jbolinger)

Previously: We should only use `protoc_options` for very high level options, not for specifying package-level configuration. For package-level values we should only look at the annotations and the configuration file (that was specified in the `protoc_options`).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.