googleapis / googleapis/gapic-generator-php

Migrate all Post Processing formatting to GAPIC generation / post processing

Open
#711 1 comment 0 reactions 0 assignees View on GitHub
priority: p3 type: feature request
Dominant language
PHP
Stars
14
Forks
18
PR merge metrics
No merged PRs in 30d

Description

See https://github.com/googleapis/synthtool/issues/1415

We are currently running the NodeJS `prettier` plugin as part of `owlbot.py`, which for obvious reasons is not ideal.

We are already using the `symplify/coding-standard` package to format the code in this library (see [`Formatter`](https://github.com/googleapis/gapic-generator-php/blob/main/src/Utils/Formatter.php)), so I'm not sure what additional formatting is even happening using the `prettier` plugin . We may be using it only for the line-lengths. And if that's the case, we should either format the line-lengths with another plugin, or decide that this is not an important enough change and remove it from `owlbot` post-processing all together.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.