googleapis / googleapis/gapic-generator-php

Edit the `AST` Class to allow to add a `;` on command.

Open
#697 1 comment 0 reactions 0 assignees View on GitHub
priority: p3 type: cleanup
Dominant language
PHP
Stars
14
Forks
18
PR merge metrics
No merged PRs in 30d

Description

We currently cannot create `resources` with the `ResourcesGenerator` without appending a `;` to the `toCode` method as if we remove the appended semicolon it ends up generating "invalid" code as it is missing the last semicolon.

In this specific case we are using a `PhpFile` class which inherits from `AST`. So there is a bit of hoops that we might need to work on in order to make be able to add a semi colon to our files when we need them.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.