googleapis / googleapis/gapic-generator-php
V2 feature request: Use strict types for new client classes
Open
priority: p1
type: feature request
v2
- Dominant language
- PHP
- Stars
- 14
- Forks
- 18
- PR merge metrics
- No merged PRs in 30d
Description
We should add "strict"types" to the new `Client` and `BaseClient` classes (and to any other net-new V2 classes).
```php
declare(strict_types=1);
```
See https://dev.to/rocksheep/the-way-stricttypes-works-in-php-eb7
**Note**: this feature was added in PHP 7.0, so we would only be able to add this after we drop support for PHP 5.6
Contributor guide
Assessment
This issue has not been assessed yet.