googleapis / googleapis/gapic-generator-csharp

Don't generate mix-ins when there aren't HTTP rules

Open
#897 7 comments 0 reactions 0 assignees View on GitHub
priority: p3 type: bug
Dominant language
C#
Stars
54
Forks
29
Avg merge
1d 7h
Merged PRs (30d)
10

Description

From https://google.aip.dev/client-libraries/4234

> To be generated into a client library, a mixin service must be declared under [apis](https://github.com/googleapis/googleapis/blob/master/google/api/service.proto#L96) in a [google.api.Service](https://github.com/googleapis/googleapis/blob/master/google/api/service.proto). Furthermore, only the RPCs with [google.api.http](https://github.com/googleapis/googleapis/blob/master/google/api/http.proto) bindings declared in the [http](https://github.com/googleapis/googleapis/blob/master/google/api/service.proto#L124) configuration of the same [google.api.Service](https://github.com/googleapis/googleapis/blob/master/google/api/service.proto) can be generated (more details on these bindings in [AIP-127](https://google.aip.dev/127)). If a mixin service RPC does not have a [google.api.http](https://github.com/googleapis/googleapis/blob/master/google/api/http.proto) rule declared in the [google.api.Service](https://github.com/googleapis/googleapis/blob/master/google/api/service.proto), it must not be generated.

I believe we generate a mixin property based only on `apis`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.