googleads / googleads/googleads-python-lib

Enable constructing GoogleServiceAccountClient with Credentials.from_service_account_info method

Open
#532 1 comment 1 reaction 1 assignee View on GitHub

@msaniscalchi is already working on this.

Since Jun 5, 2024.

enhancement
Dominant language
Python
Stars
749
Forks
967
No merged PRs in 30d

Description

When initializing a GoogleServiceAccountClient, it expects Service Account JSON key file but there is no way to pass in the key file content as dictionary (e.g. after reading out from a secret store) because the constructor is limited to use the google.oauth2.service_account.Credentials.from_service_account_file()class method. Can this constructor be extended with .from_service_account_info() method, too?

https://google-auth.readthedocs.io/en/master/reference/google.oauth2.service_account.html#google.oauth2.service_account.Credentials.from_service_account_info

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.