googleads / googleads/googleads-python-lib
live_stream_events_service.performLiveStreamEventAction({'xsi_type': 'ActivateLiveStreamEvents'}, <Live_Streams_List>) executed and impacted all Live Streams configs
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 749
- Forks
- 967
- PR merge metrics
- No merged PRs in 30d
Description
Variable Def -
Set ID of the LiveStreamEvent to get live stream events from.
LIVE_STREAM_EVENT_ID = 'INSERT_LIVE_STREAM_EVENT_ID_HERE'
Incorrect Usage -
statement = (ad_manager.StatementBuilder(version='v202002')
.Where(('Id = :id'))
.WithBindVariable('id', int(live_stream_event_id))
.Limit(500))
Considering event id is not found via statement query will return all Live Streams and accidentally causing updateLiveStreamEvents to all LiveStreams
live_stream_events = live_stream_events_service.updateLiveStreamEvents(
updated_live_stream_events)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with examples/ad_manager/v202002/live_stream_event_service/update_live_stream_events.py around line 26 and review how the StatementBuilder handles the requested event ID. Reproduce the missing-ID case with the example's live stream event lookup. Done means an absent or invalid ID cannot cause updateLiveStreamEvents to affect all Live Streams configs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100