googleads / googleads/google-ads-ruby

Allow user to provide with additional GRPC interceptors

Open
#106 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

difficulty: medium enhancement
Dominant language
Ruby
Stars
83
Forks
72
Avg merge
16m
Merged PRs (30d)
1

Description

It would be great to have a possibility to provide with own interceptors for service initialization since there is currently no way to inject there. Ideally (or additionally) in a global manner so this could be configured without modifying client/service initialization code and interceptor could be injected dynamically in tests (to fake requests).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading lib/google/ads/google_ads/google_ads_client.rb around line 127, where service initialization currently prevents interceptor injection. Determine how callers could provide interceptors, including a global configuration path and dynamic injection for tests; done means both initialization and test faking can use caller-supplied interceptors without modifying client or service initialization code.

Written by the indexing model from the issue text.

Assessment

Tech stack
grpc, ruby
Domain
api, backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.