google / google/zetasketch

HyperLogLogPlusPlus should be serializable

Open
#3 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
169
Forks
23
PR merge metrics
No merged PRs in 30d

Description

To allow inclusion of this in systems like Apache Beam and Apache Flink the HyperLogLogPlusPlus class should be serializable.
I ran into this while trying to implement a UDF for Apache Flink, there serializability is mandatory.

Also when trying to put an instance of the HyperLogLogPlusPlus class through a simple Beam pipeline resulted in
```
Caused by: java.io.NotSerializableException: com.google.zetasketch.HyperLogLogPlusPlus
at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1184)
at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1548)
at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1509)

```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.