google / google/zerocopy

Update language to refer to `u8`s instead of bytes

Open
#278 1 comment 0 reactions 0 assignees View on GitHub
compatibility-nonbreaking
Dominant language
Rust
Stars
2.6k
Forks
179
Avg merge
1d 19h
Merged PRs (30d)
29

Description

As [this discussion](https://github.com/rust-lang/reference/pull/1392#discussion_r1294842256) demonstrates, there is a lot of subtlety around what constitutes a "byte" in Rust's abstract machine. By contrast, it is sufficient to define the bit validity of most types in reference to `u8`s without actually specifying much about the bit validity of `u8` itself. Since most of our conversions operate in terms of existing `u8` types (usually `[u8]`), this isn't a problem for us. We should replace most uses of "byte sequence" with a similar phrase involving `u8`s.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.