google / google/yapf

Bug adding large whitespace before `)` (and then remove on second format)

Open
#911 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
14k
Forks
904
PR merge metrics
No merged PRs in 30d

Description

Take this change in ANGLE: https://chromium-review.googlesource.com/c/angle/angle/+/2807780
When running `$ git cl format` (from depot tools), it produces the following change:

```
src/libANGLE/renderer/metal/gen_mtl_format_table.py:
- !display->getFeatures().forceD24S8AsUnsupported.enabled")
+ !display->getFeatures().forceD24S8AsUnsupported.enabled" )
```

Running `git cl format` again will revert the above change. The addition of whitespace before `)` isn't right. I'd appreciate if this could be resolved quickly as clean formatting is a requirement in ANGLE to submit changes. Alternatively, I could attempt to change the code in such a way to not trigger the bug if you can figure out what's causing it.

Note: to get ANGLE's code, follow this: https://chromium.googlesource.com/angle/angle/+/master/README.md#sources

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.