google / google/yapf

EACH_DICT_ENTRY_ON_SEPARATE_LINE for OrderedDict?

Open
#468 3 comments 2 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
14k
Forks
904
PR merge metrics
No merged PRs in 30d

Description

Here's a diff before and after yapf with google style:
```python
-all_processes = OrderedDict([(PROCESS_TYPE_MONITOR, []),
- (PROCESS_TYPE_LOG_MONITOR, []),
- (PROCESS_TYPE_WORKER, []),
- (PROCESS_TYPE_LOCAL_SCHEDULER, []),
- (PROCESS_TYPE_PLASMA_MANAGER, []),
- (PROCESS_TYPE_PLASMA_STORE, []),
- (PROCESS_TYPE_GLOBAL_SCHEDULER, []),
- (PROCESS_TYPE_REDIS_SERVER, []),
- (PROCESS_TYPE_WEB_UI, [])],)
+all_processes = OrderedDict(
+ [(PROCESS_TYPE_MONITOR, []), (PROCESS_TYPE_LOG_MONITOR, []),
+ (PROCESS_TYPE_WORKER, []), (PROCESS_TYPE_LOCAL_SCHEDULER,
+ []), (PROCESS_TYPE_PLASMA_MANAGER, []),
+ (PROCESS_TYPE_PLASMA_STORE, []), (PROCESS_TYPE_GLOBAL_SCHEDULER,
+ []), (PROCESS_TYPE_REDIS_SERVER,
+ []), (PROCESS_TYPE_WEB_UI, [])], )
```
I think we can agree the before version is more readable ;) I can think of several possibilities:
* Is there a `EACH_DICT_ENTRY_ON_SEPARATE_LINE` counterpart for `OrderedDict`?
+ Or each list entry on separate line?
* As a workaround I currently just disable yapf for this statement.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.