google / google/yapf

Odd formatting of string formatting and long arguments

Open
#426 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
14k
Forks
904
PR merge metrics
No merged PRs in 30d

Description

Hi there,

YAPF 0.16.3 with default settings formats code like this:

```
def get_prometheus_expression(self, label_filters, expressions, do_filter):
return '(%s) %s (%s)' % (self._left.get_prometheus_expression(
label_filters, expressions, do_filter),
self._right.get_prometheus_expression(
label_filters, expressions, do_filter))
```

Even though I would expect it to format this code like this:

```
def get_prometheus_expression(self, label_filters, expressions, do_filter):
return '(%s) %s (%s)' % (self._left.get_prometheus_expression(
label_filters, expressions, do_filter),
self._right.get_prometheus_expression(
label_filters, expressions, do_filter))
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.